diff options
| author | Lioncash <mathew1800@gmail.com> | 2019-04-05 22:51:22 -0400 |
|---|---|---|
| committer | Lioncash <mathew1800@gmail.com> | 2019-04-05 22:55:13 -0400 |
| commit | 1efdb4897ed80a12b3d6fd2ec0575c86d60d95de (patch) | |
| tree | 814e11eff276ea38f2173868d0b0e1a8f6452d28 /src/video_core/macro_interpreter.cpp | |
| parent | 66be5150d6d201e3f8ca6e5e09968f052df4beb1 (diff) | |
video_core/macro_interpreter: Simplify GetRegister()
Given we already ensure nothing can set the zeroth register in
SetRegister(), we don't need to check if the index is zero and special
case it. We can just access the register normally, since it's already
going to be zero.
We can also replace the assertion with .at() to perform the equivalent
behavior inline as part of the API.
Diffstat (limited to 'src/video_core/macro_interpreter.cpp')
| -rw-r--r-- | src/video_core/macro_interpreter.cpp | 17 |
1 files changed, 6 insertions, 11 deletions
diff --git a/src/video_core/macro_interpreter.cpp b/src/video_core/macro_interpreter.cpp index 64f75db436..4c4e8d603a 100644 --- a/src/video_core/macro_interpreter.cpp +++ b/src/video_core/macro_interpreter.cpp @@ -228,22 +228,17 @@ u32 MacroInterpreter::FetchParameter() { } u32 MacroInterpreter::GetRegister(u32 register_id) const { - // Register 0 is supposed to always return 0. - if (register_id == 0) - return 0; - - ASSERT(register_id < registers.size()); - return registers[register_id]; + return registers.at(register_id); } void MacroInterpreter::SetRegister(u32 register_id, u32 value) { - // Register 0 is supposed to always return 0. NOP is implemented as a store to the zero - // register. - if (register_id == 0) + // Register 0 is hardwired as the zero register. + // Ensure no writes to it actually occur. + if (register_id == 0) { return; + } - ASSERT(register_id < registers.size()); - registers[register_id] = value; + registers.at(register_id) = value; } void MacroInterpreter::SetMethodAddress(u32 address) { |