diff options
| author | James Rowe <jroweboy@gmail.com> | 2018-07-14 11:57:13 -0600 |
|---|---|---|
| committer | James Rowe <jroweboy@gmail.com> | 2018-07-14 11:57:13 -0600 |
| commit | 6daebaaa5798ec7e104ac7a2221b1310a0ba0116 (patch) | |
| tree | 29ed68ebb6cf2b2da1a14f922167b71dda624c14 /src/common/logging/backend.cpp | |
| parent | b30c5370b10a4a0fc2710067c8faa72ea03a5f80 (diff) | |
Logging: Don't lock the queue for the duration of the write
Diffstat (limited to 'src/common/logging/backend.cpp')
| -rw-r--r-- | src/common/logging/backend.cpp | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/src/common/logging/backend.cpp b/src/common/logging/backend.cpp index 242914c6ae..5313b85103 100644 --- a/src/common/logging/backend.cpp +++ b/src/common/logging/backend.cpp @@ -83,8 +83,10 @@ private: } }; while (true) { - std::unique_lock<std::mutex> lock(message_mutex); - message_cv.wait(lock, [&] { return !running || message_queue.Pop(entry); }); + { + std::unique_lock<std::mutex> lock(message_mutex); + message_cv.wait(lock, [&] { return !running || message_queue.Pop(entry); }); + } if (!running) { break; } @@ -282,4 +284,4 @@ void FmtLogMessageImpl(Class log_class, Level log_level, const char* filename, Impl::Instance().PushEntry(std::move(entry)); } -} // namespace Log
\ No newline at end of file +} // namespace Log |