diff options
| author | Lioncash <mathew1800@gmail.com> | 2021-04-20 12:57:45 -0400 |
|---|---|---|
| committer | Lioncash <mathew1800@gmail.com> | 2021-04-20 12:57:49 -0400 |
| commit | 6125590a7b2bbad7d5efdfbab69ba86601e0769b (patch) | |
| tree | c420bcf8709cf5af735988fddf25bba63ddbd2eb /src/common/logging/backend.cpp | |
| parent | aaaca1cd6d1c4bb27e4fe3464293dcfffd8d886b (diff) | |
log/backend: Use in-class initializer for FileBackend
We can also avoid redundant constructions of the same string repeatedly.
Diffstat (limited to 'src/common/logging/backend.cpp')
| -rw-r--r-- | src/common/logging/backend.cpp | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/src/common/logging/backend.cpp b/src/common/logging/backend.cpp index f0bb392c64..96efa977d8 100644 --- a/src/common/logging/backend.cpp +++ b/src/common/logging/backend.cpp @@ -148,12 +148,14 @@ void ColorConsoleBackend::Write(const Entry& entry) { PrintColoredMessage(entry); } -FileBackend::FileBackend(const std::string& filename) : bytes_written(0) { - if (FS::Exists(filename + ".old.txt")) { - FS::Delete(filename + ".old.txt"); +FileBackend::FileBackend(const std::string& filename) { + const auto old_filename = filename + ".old.txt"; + + if (FS::Exists(old_filename)) { + FS::Delete(old_filename); } if (FS::Exists(filename)) { - FS::Rename(filename, filename + ".old.txt"); + FS::Rename(filename, old_filename); } // _SH_DENYWR allows read only access to the file for other programs. |