diff options
| author | Liam <byteslice@airmail.cc> | 2022-06-07 17:02:29 -0400 |
|---|---|---|
| committer | Liam <byteslice@airmail.cc> | 2022-06-13 20:09:00 -0400 |
| commit | 084d7d6b014443be7625fb9d8f1ddd309a22f6f4 (patch) | |
| tree | ea48c7b1d22a0b282846ba28a9b62c988e38bd29 /src/common/assert.h | |
| parent | bd3bfe411d8319b8300037a78c152ad7dab839f3 (diff) | |
common: Change semantics of UNREACHABLE to unconditionally crash
Diffstat (limited to 'src/common/assert.h')
| -rw-r--r-- | src/common/assert.h | 14 |
1 files changed, 12 insertions, 2 deletions
diff --git a/src/common/assert.h b/src/common/assert.h index dbfd8abaf6..478bfa8565 100644 --- a/src/common/assert.h +++ b/src/common/assert.h @@ -11,6 +11,8 @@ // everywhere. So let's just move the handling of the failed assert to a single cpp file. void assert_handle_failure(); +[[noreturn]] void unreachable_impl(); + // For asserts we'd like to keep all the junk executed when an assert happens away from the // important code in the function. One way of doing this is to put all the relevant code inside a // lambda and force the compiler to not inline it. Unfortunately, MSVC seems to have no syntax to @@ -44,9 +46,17 @@ assert_noinline_call(const Fn& fn) { } \ while (0) -#define UNREACHABLE() assert_noinline_call([] { LOG_CRITICAL(Debug, "Unreachable code!"); }) +#define UNREACHABLE() \ + do { \ + assert_noinline_call([] { LOG_CRITICAL(Debug, "Unreachable code!"); }); \ + unreachable_impl(); \ + } while (0) + #define UNREACHABLE_MSG(...) \ - assert_noinline_call([&] { LOG_CRITICAL(Debug, "Unreachable code!\n" __VA_ARGS__); }) + do { \ + assert_noinline_call([&] { LOG_CRITICAL(Debug, "Unreachable code!\n" __VA_ARGS__); }); \ + unreachable_impl(); \ + } while (0) #ifdef _DEBUG #define DEBUG_ASSERT(_a_) ASSERT(_a_) |