diff options
| author | Lioncash <mathew1800@gmail.com> | 2018-09-11 21:36:07 -0400 |
|---|---|---|
| committer | Lioncash <mathew1800@gmail.com> | 2018-09-11 21:36:12 -0400 |
| commit | bad035e9a34cd247ca54a4cd4ca75ac2ae6b185b (patch) | |
| tree | 076dceebf2c67336930accf70ab7caa00e020efc | |
| parent | 1470b85af9027106f16c888bb7f6a97d44fad304 (diff) | |
audio_core/sink_details: Change std::string parameter into std::string_view
The given string is only ever used for lookup and comparison, so we can
just utilize a non-owning view to string data here
| -rw-r--r-- | src/audio_core/sink_details.cpp | 2 | ||||
| -rw-r--r-- | src/audio_core/sink_details.h | 4 |
2 files changed, 4 insertions, 2 deletions
diff --git a/src/audio_core/sink_details.cpp b/src/audio_core/sink_details.cpp index 955ba20fb4..67cf1f3b27 100644 --- a/src/audio_core/sink_details.cpp +++ b/src/audio_core/sink_details.cpp @@ -24,7 +24,7 @@ const std::vector<SinkDetails> g_sink_details = { [] { return std::vector<std::string>{"null"}; }}, }; -const SinkDetails& GetSinkDetails(std::string sink_id) { +const SinkDetails& GetSinkDetails(std::string_view sink_id) { auto iter = std::find_if(g_sink_details.begin(), g_sink_details.end(), [sink_id](const auto& sink_detail) { return sink_detail.id == sink_id; }); diff --git a/src/audio_core/sink_details.h b/src/audio_core/sink_details.h index ea666c5549..03534b1875 100644 --- a/src/audio_core/sink_details.h +++ b/src/audio_core/sink_details.h @@ -6,6 +6,8 @@ #include <functional> #include <memory> +#include <string> +#include <string_view> #include <utility> #include <vector> @@ -30,6 +32,6 @@ struct SinkDetails { extern const std::vector<SinkDetails> g_sink_details; -const SinkDetails& GetSinkDetails(std::string sink_id); +const SinkDetails& GetSinkDetails(std::string_view sink_id); } // namespace AudioCore |