diff options
author | Morph <39850852+Morph1984@users.noreply.github.com> | 2021-06-13 07:47:57 -0400 |
---|---|---|
committer | Morph <39850852+Morph1984@users.noreply.github.com> | 2021-06-13 07:47:57 -0400 |
commit | a98b6c8f0759232fbb19ca611f954943f3f0b7af (patch) | |
tree | fe92de3d998de6742f4506de9fcf7b798252e37c | |
parent | 56afd4ab4bdba2a9f203042c286589be95849aef (diff) |
common: fs: file: Flush the file to the disk when Flush() is called
std::fflush does not guarantee that file buffers are flushed to the disk.
Use _commit on Windows and fsync on all other OSes to ensure that the file is flushed to the disk.
-rw-r--r-- | src/common/fs/file.cpp | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/src/common/fs/file.cpp b/src/common/fs/file.cpp index 9f3de1cb03..c84f31f3e1 100644 --- a/src/common/fs/file.cpp +++ b/src/common/fs/file.cpp @@ -309,7 +309,11 @@ bool IOFile::Flush() const { errno = 0; - const auto flush_result = std::fflush(file) == 0; +#ifdef _WIN32 + const auto flush_result = std::fflush(file) == 0 && _commit(fileno(file)) == 0; +#else + const auto flush_result = std::fflush(file) == 0 && fsync(fileno(file)) == 0; +#endif if (!flush_result) { const auto ec = std::error_code{errno, std::generic_category()}; |