diff options
| author | bunnei <bunneidev@gmail.com> | 2020-08-05 23:20:23 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-08-05 23:20:23 -0400 |
| commit | 1cc0e4b4d81af64217cb488375af97dfbc8f984f (patch) | |
| tree | 95e55d849d7aaa210f4ad2835c0a45f0a6a7999a | |
| parent | 35c1607f231cab060305e79f434ef15442c162f1 (diff) | |
| parent | a77ee63f65ba34d91944e168a9ba29464cef12b1 (diff) | |
Merge pull request #4489 from lioncash/typesafe
ipc_helpers: Only allow trivially copyable objects with PushRaw() and PopRaw()
| -rw-r--r-- | src/core/hle/ipc_helpers.h | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/src/core/hle/ipc_helpers.h b/src/core/hle/ipc_helpers.h index 0dc6a4a437..1b503331fb 100644 --- a/src/core/hle/ipc_helpers.h +++ b/src/core/hle/ipc_helpers.h @@ -229,6 +229,8 @@ inline void ResponseBuilder::Push(u32 value) { template <typename T> void ResponseBuilder::PushRaw(const T& value) { + static_assert(std::is_trivially_copyable_v<T>, + "It's undefined behavior to use memcpy with non-trivially copyable objects"); std::memcpy(cmdbuf + index, &value, sizeof(T)); index += (sizeof(T) + 3) / 4; // round up to word length } @@ -384,6 +386,8 @@ inline s32 RequestParser::Pop() { template <typename T> void RequestParser::PopRaw(T& value) { + static_assert(std::is_trivially_copyable_v<T>, + "It's undefined behavior to use memcpy with non-trivially copyable objects"); std::memcpy(&value, cmdbuf + index, sizeof(T)); index += (sizeof(T) + 3) / 4; // round up to word length } |