aboutsummaryrefslogtreecommitdiff
path: root/src/Ryujinx.Memory/Tracking/MultiRegionHandle.cs
diff options
context:
space:
mode:
authorTSRBerry <20988865+TSRBerry@users.noreply.github.com>2023-06-28 18:34:00 +0200
committerGitHub <noreply@github.com>2023-06-28 18:34:00 +0200
commit0a75b73fa43ddadf561ddeb0f923c6f3811c025b (patch)
tree402bfc83772498c26468115f5a73c7a8f07deae2 /src/Ryujinx.Memory/Tracking/MultiRegionHandle.cs
parent46b7c905f5dbb8c7e527281e22d5d2fc36bc666f (diff)
[Ryujinx.Memory] Address dotnet-format issues (#5386)1.1.935
* dotnet format style --severity info Some changes were manually reverted. * dotnet format analyzers --serverity info Some changes have been minimally adapted. * Silence dotnet format IDE0059 warnings * Address or silence dotnet format IDE1006 warnings * Address dotnet format CA1816 warnings * Address or silence dotnet format CA1069 warnings * Address remaining dotnet format analyzer warnings * Address review comments * Address most dotnet format whitespace warnings * Apply dotnet format whitespace formatting A few of them have been manually reverted and the corresponding warning was silenced * Format if-blocks correctly * Another rebase, another dotnet format run * Run dotnet format after rebase and remove unused usings - analyzers - style - whitespace * Add comments to disabled warnings * Simplify properties and array initialization, Use const when possible, Remove trailing commas * Revert "Simplify properties and array initialization, Use const when possible, Remove trailing commas" This reverts commit 9462e4136c0a2100dc28b20cf9542e06790aa67e. * dotnet format whitespace after rebase * Address review feedback * Assign Decommit to ReplacePlaceholder * Run final dotnet format pass * Organize imports again * Add trailing commas * Add missing newline
Diffstat (limited to 'src/Ryujinx.Memory/Tracking/MultiRegionHandle.cs')
-rw-r--r--src/Ryujinx.Memory/Tracking/MultiRegionHandle.cs11
1 files changed, 7 insertions, 4 deletions
diff --git a/src/Ryujinx.Memory/Tracking/MultiRegionHandle.cs b/src/Ryujinx.Memory/Tracking/MultiRegionHandle.cs
index 68fc5e75..5d3f20f4 100644
--- a/src/Ryujinx.Memory/Tracking/MultiRegionHandle.cs
+++ b/src/Ryujinx.Memory/Tracking/MultiRegionHandle.cs
@@ -1,5 +1,6 @@
using System;
using System.Collections.Generic;
+using System.Linq;
using System.Numerics;
using System.Runtime.CompilerServices;
using System.Threading;
@@ -21,11 +22,11 @@ namespace Ryujinx.Memory.Tracking
private readonly ulong Granularity;
private readonly ulong Size;
- private ConcurrentBitmap _dirtyBitmap;
+ private readonly ConcurrentBitmap _dirtyBitmap;
private int _sequenceNumber;
- private BitMap _sequenceNumberBitmap;
- private BitMap _dirtyCheckedBitmap;
+ private readonly BitMap _sequenceNumberBitmap;
+ private readonly BitMap _dirtyCheckedBitmap;
private int _uncheckedHandles;
public bool Dirty { get; private set; } = true;
@@ -54,7 +55,7 @@ namespace Ryujinx.Memory.Tracking
// It is assumed that the provided handles do not overlap, in order, are on page boundaries,
// and don't extend past the requested range.
- foreach (RegionHandle handle in handles)
+ foreach (RegionHandle handle in handles.Cast<RegionHandle>())
{
int startIndex = (int)((handle.RealAddress - address) / granularity);
@@ -406,6 +407,8 @@ namespace Ryujinx.Memory.Tracking
public void Dispose()
{
+ GC.SuppressFinalize(this);
+
foreach (var handle in _handles)
{
handle.Dispose();