aboutsummaryrefslogtreecommitdiff
path: root/src/Ryujinx.HLE/Loaders/Mods/IPSPatcher.cs
diff options
context:
space:
mode:
authorTSRBerry <20988865+TSRBerry@users.noreply.github.com>2023-07-16 19:31:14 +0200
committerGitHub <noreply@github.com>2023-07-16 19:31:14 +0200
commit326749498bed4360e5a4b11fc67d5ec7cb9a3076 (patch)
treeae21fb26f99b401ca4e9efaab72b679a81c22369 /src/Ryujinx.HLE/Loaders/Mods/IPSPatcher.cs
parentfec8291c17fa106c28f58b56419e90d49a41a1ea (diff)
[Ryujinx.HLE] Address dotnet-format issues (#5380)1.1.962
* dotnet format style --severity info Some changes were manually reverted. * dotnet format analyzers --serverity info Some changes have been minimally adapted. * Restore a few unused methods and variables * Silence dotnet format IDE0060 warnings * Silence dotnet format IDE0052 warnings * Address or silence dotnet format IDE1006 warnings * Address dotnet format CA1816 warnings * Address or silence dotnet format CA2208 warnings * Address or silence dotnet format CA1806 and a few CA1854 warnings * Address dotnet format CA2211 warnings * Address dotnet format CA1822 warnings * Address or silence dotnet format CA1069 warnings * Make dotnet format succeed in style mode * Address or silence dotnet format CA2211 warnings * Address review comments * Address dotnet format CA2208 warnings properly * Make ProcessResult readonly * Address most dotnet format whitespace warnings * Apply dotnet format whitespace formatting A few of them have been manually reverted and the corresponding warning was silenced * Add previously silenced warnings back I have no clue how these disappeared * Revert formatting changes for while and for-loops * Format if-blocks correctly * Run dotnet format style after rebase * Run dotnet format whitespace after rebase * Run dotnet format style after rebase * Run dotnet format analyzers after rebase * Run dotnet format after rebase and remove unused usings - analyzers - style - whitespace * Disable 'prefer switch expression' rule * Add comments to disabled warnings * Fix a few disabled warnings * Fix naming rule violation, Convert shader properties to auto-property and convert values to const * Simplify properties and array initialization, Use const when possible, Remove trailing commas * Start working on disabled warnings * Fix and silence a few dotnet-format warnings again * Run dotnet format after rebase * Use using declaration instead of block syntax * Address IDE0251 warnings * Address a few disabled IDE0060 warnings * Silence IDE0060 in .editorconfig * Revert "Simplify properties and array initialization, Use const when possible, Remove trailing commas" This reverts commit 9462e4136c0a2100dc28b20cf9542e06790aa67e. * dotnet format whitespace after rebase * First dotnet format pass * Fix naming rule violations * Fix typo * Add trailing commas, use targeted new and use array initializer * Fix build issues * Fix remaining build issues * Remove SuppressMessage for CA1069 where possible * Address dotnet format issues * Address formatting issues Co-authored-by: Ac_K <acoustik666@gmail.com> * Add GetHashCode implementation for RenderingSurfaceInfo * Explicitly silence CA1822 for every affected method in Syscall * Address formatting issues in Demangler.cs * Address review feedback Co-authored-by: Ac_K <acoustik666@gmail.com> * Revert marking service methods as static * Next dotnet format pass * Address review feedback --------- Co-authored-by: Ac_K <acoustik666@gmail.com>
Diffstat (limited to 'src/Ryujinx.HLE/Loaders/Mods/IPSPatcher.cs')
-rw-r--r--src/Ryujinx.HLE/Loaders/Mods/IPSPatcher.cs27
1 files changed, 13 insertions, 14 deletions
diff --git a/src/Ryujinx.HLE/Loaders/Mods/IPSPatcher.cs b/src/Ryujinx.HLE/Loaders/Mods/IPSPatcher.cs
index 510fec05..cf316b56 100644
--- a/src/Ryujinx.HLE/Loaders/Mods/IPSPatcher.cs
+++ b/src/Ryujinx.HLE/Loaders/Mods/IPSPatcher.cs
@@ -1,13 +1,12 @@
using Ryujinx.Common.Logging;
using System;
using System.IO;
-using System.Text;
namespace Ryujinx.HLE.Loaders.Mods
{
class IpsPatcher
{
- MemPatch _patches;
+ readonly MemPatch _patches;
public IpsPatcher(BinaryReader reader)
{
@@ -20,15 +19,15 @@ namespace Ryujinx.HLE.Loaders.Mods
private static MemPatch ParseIps(BinaryReader reader)
{
- ReadOnlySpan<byte> IpsHeaderMagic = "PATCH"u8;
- ReadOnlySpan<byte> IpsTailMagic = "EOF"u8;
- ReadOnlySpan<byte> Ips32HeaderMagic = "IPS32"u8;
- ReadOnlySpan<byte> Ips32TailMagic = "EEOF"u8;
+ ReadOnlySpan<byte> ipsHeaderMagic = "PATCH"u8;
+ ReadOnlySpan<byte> ipsTailMagic = "EOF"u8;
+ ReadOnlySpan<byte> ips32HeaderMagic = "IPS32"u8;
+ ReadOnlySpan<byte> ips32TailMagic = "EEOF"u8;
- MemPatch patches = new MemPatch();
- var header = reader.ReadBytes(IpsHeaderMagic.Length).AsSpan();
+ MemPatch patches = new();
+ var header = reader.ReadBytes(ipsHeaderMagic.Length).AsSpan();
- if (header.Length != IpsHeaderMagic.Length)
+ if (header.Length != ipsHeaderMagic.Length)
{
return null;
}
@@ -36,15 +35,15 @@ namespace Ryujinx.HLE.Loaders.Mods
bool is32;
ReadOnlySpan<byte> tailSpan;
- if (header.SequenceEqual(IpsHeaderMagic))
+ if (header.SequenceEqual(ipsHeaderMagic))
{
is32 = false;
- tailSpan = IpsTailMagic;
+ tailSpan = ipsTailMagic;
}
- else if (header.SequenceEqual(Ips32HeaderMagic))
+ else if (header.SequenceEqual(ips32HeaderMagic))
{
is32 = true;
- tailSpan = Ips32TailMagic;
+ tailSpan = ips32TailMagic;
}
else
{
@@ -114,4 +113,4 @@ namespace Ryujinx.HLE.Loaders.Mods
patches.AddFrom(_patches);
}
}
-} \ No newline at end of file
+}