diff options
| author | TSRBerry <20988865+TSRBerry@users.noreply.github.com> | 2023-06-28 18:41:38 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-06-28 18:41:38 +0200 |
| commit | fc20d9b925b83532a19467293a7cdcbaa4ef3d6b (patch) | |
| tree | ebe0e690b6644d0f825ee80f20e4067855f35cf4 /src/Ryujinx.Common/Memory/SpanReader.cs | |
| parent | 0a75b73fa43ddadf561ddeb0f923c6f3811c025b (diff) | |
[Ryujinx.Common] Address dotnet-format issues (#5358)1.1.936
* dotnet format style --severity info
Some changes were manually reverted.
* dotnet format analyzers --serverity info
Some changes have been minimally adapted.
* Restore a few unused methods and variables
* Silence dotnet format IDE0060 warnings
* Silence dotnet format IDE0059 warnings
* Address or silence dotnet format IDE1006 warnings
* Address dotnet format CA1816 warnings
* Address or silence dotnet format CA2211 warnings
* Silence CA1806 and CA1834 issues
* Fix formatting for switch expressions
* Address most dotnet format whitespace warnings
* Apply dotnet format whitespace formatting
A few of them have been manually reverted and the corresponding warning was silenced
* Revert formatting changes for while and for-loops
* Format if-blocks correctly
* Run dotnet format whitespace after rebase
* Run dotnet format style after rebase
* Run dotnet format analyzers after rebase
* Run dotnet format after rebase and remove unused usings
- analyzers
- style
- whitespace
* Add comments to disabled warnings
* Remove a few unused parameters
* Replace MmeShadowScratch with Array256<uint>
* Simplify properties and array initialization, Use const when possible, Remove trailing commas
* Run dotnet format after rebase
* Address IDE0251 warnings
* Revert "Simplify properties and array initialization, Use const when possible, Remove trailing commas"
This reverts commit 9462e4136c0a2100dc28b20cf9542e06790aa67e.
* dotnet format whitespace after rebase
* First dotnet format pass
* Second dotnet format pass
* Fix build issues
* Fix StructArrayHelpers.cs
* Apply suggestions from code review
Co-authored-by: Ac_K <Acoustik666@gmail.com>
* Fix return statements
* Fix naming rule violations
* Update src/Ryujinx.Common/Utilities/StreamUtils.cs
Co-authored-by: Ac_K <Acoustik666@gmail.com>
* Add trailing commas
* Address review feedback
* Address review feedback
* Rename remaining type parameters to TKey and TValue
* Fix manual formatting for logging levels
* Fix spacing before comments
---------
Co-authored-by: Ac_K <Acoustik666@gmail.com>
Diffstat (limited to 'src/Ryujinx.Common/Memory/SpanReader.cs')
| -rw-r--r-- | src/Ryujinx.Common/Memory/SpanReader.cs | 20 |
1 files changed, 10 insertions, 10 deletions
diff --git a/src/Ryujinx.Common/Memory/SpanReader.cs b/src/Ryujinx.Common/Memory/SpanReader.cs index 9a1a0a3f..946439e3 100644 --- a/src/Ryujinx.Common/Memory/SpanReader.cs +++ b/src/Ryujinx.Common/Memory/SpanReader.cs @@ -8,7 +8,7 @@ namespace Ryujinx.Common.Memory { private ReadOnlySpan<byte> _input; - public int Length => _input.Length; + public readonly int Length => _input.Length; public SpanReader(ReadOnlySpan<byte> input) { @@ -19,7 +19,7 @@ namespace Ryujinx.Common.Memory { T value = MemoryMarshal.Cast<byte, T>(_input)[0]; - _input = _input.Slice(Unsafe.SizeOf<T>()); + _input = _input[Unsafe.SizeOf<T>()..]; return value; } @@ -37,16 +37,16 @@ namespace Ryujinx.Common.Memory value = MemoryMarshal.Cast<byte, T>(_input)[0]; - _input = _input.Slice(valueSize); + _input = _input[valueSize..]; return true; } public ReadOnlySpan<byte> GetSpan(int size) { - ReadOnlySpan<byte> data = _input.Slice(0, size); + ReadOnlySpan<byte> data = _input[..size]; - _input = _input.Slice(size); + _input = _input[size..]; return data; } @@ -56,19 +56,19 @@ namespace Ryujinx.Common.Memory return GetSpan((int)Math.Min((uint)_input.Length, (uint)size)); } - public T ReadAt<T>(int offset) where T : unmanaged + public readonly T ReadAt<T>(int offset) where T : unmanaged { - return MemoryMarshal.Cast<byte, T>(_input.Slice(offset))[0]; + return MemoryMarshal.Cast<byte, T>(_input[offset..])[0]; } - public ReadOnlySpan<byte> GetSpanAt(int offset, int size) + public readonly ReadOnlySpan<byte> GetSpanAt(int offset, int size) { return _input.Slice(offset, size); } public void Skip(int size) { - _input = _input.Slice(size); + _input = _input[size..]; } } -}
\ No newline at end of file +} |