diff options
| author | Ameer J <52414509+ameerj@users.noreply.github.com> | 2021-09-12 21:06:52 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-09-12 21:06:52 -0400 |
| commit | d180fd7c360f52a807d7a4aeaaffd5d736cbab6a (patch) | |
| tree | 850fb8eb278fcbdba88cfbf280ca03404763c45c | |
| parent | e4318d2207e352b3c661af3d72c62903b0d0ce58 (diff) | |
| parent | 727f607e00e0ac4e2e0efe5b5525f342e0814de7 (diff) | |
Merge pull request #7000 from Morph1984/create-dir-comment
FS: Mark recursive CreateDirectory as inaccurate and temporary
| -rw-r--r-- | src/core/hle/service/filesystem/filesystem.cpp | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/src/core/hle/service/filesystem/filesystem.cpp b/src/core/hle/service/filesystem/filesystem.cpp index db17d61e4b..c8d65f3282 100644 --- a/src/core/hle/service/filesystem/filesystem.cpp +++ b/src/core/hle/service/filesystem/filesystem.cpp @@ -97,6 +97,11 @@ ResultCode VfsDirectoryServiceWrapper::DeleteFile(const std::string& path_) cons ResultCode VfsDirectoryServiceWrapper::CreateDirectory(const std::string& path_) const { std::string path(Common::FS::SanitizePath(path_)); + + // NOTE: This is inaccurate behavior. CreateDirectory is not recursive. + // CreateDirectory should return PathNotFound if the parent directory does not exist. + // This is here temporarily in order to have UMM "work" in the meantime. + // TODO (Morph): Remove this when a hardware test verifies the correct behavior. const auto components = Common::FS::SplitPathComponents(path); std::string relative_path; for (const auto& component : components) { |