diff options
| author | Liam <byteslice@airmail.cc> | 2023-05-07 16:33:35 -0400 |
|---|---|---|
| committer | Liam <byteslice@airmail.cc> | 2023-05-07 19:03:41 -0400 |
| commit | d100de27ee77fc98e1f3fa3dc6d2db0999da0a1a (patch) | |
| tree | c2764ab9a2b1096d58e8735170bbb3882169cdca | |
| parent | 5792a72c29dbc7af6a28603136206e97ef58943d (diff) | |
vfs_layered: avoid n^2 lookup in layeredfs building
| -rw-r--r-- | src/core/file_sys/vfs_layered.cpp | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/src/core/file_sys/vfs_layered.cpp b/src/core/file_sys/vfs_layered.cpp index da05dd3958..3e6426afc8 100644 --- a/src/core/file_sys/vfs_layered.cpp +++ b/src/core/file_sys/vfs_layered.cpp @@ -2,6 +2,7 @@ // SPDX-License-Identifier: GPL-2.0-or-later #include <algorithm> +#include <set> #include <utility> #include "core/file_sys/vfs_layered.h" @@ -58,11 +59,13 @@ std::string LayeredVfsDirectory::GetFullPath() const { std::vector<VirtualFile> LayeredVfsDirectory::GetFiles() const { std::vector<VirtualFile> out; + std::set<std::string, std::less<>> out_names; + for (const auto& layer : dirs) { for (const auto& file : layer->GetFiles()) { - if (std::find_if(out.begin(), out.end(), [&file](const VirtualFile& comp) { - return comp->GetName() == file->GetName(); - }) == out.end()) { + auto file_name = file->GetName(); + if (!out_names.contains(file_name)) { + out_names.emplace(std::move(file_name)); out.push_back(file); } } |