From 326749498bed4360e5a4b11fc67d5ec7cb9a3076 Mon Sep 17 00:00:00 2001
From: TSRBerry <20988865+TSRBerry@users.noreply.github.com>
Date: Sun, 16 Jul 2023 19:31:14 +0200
Subject: [Ryujinx.HLE] Address dotnet-format issues (#5380)

* dotnet format style --severity info

Some changes were manually reverted.

* dotnet format analyzers --serverity info

Some changes have been minimally adapted.

* Restore a few unused methods and variables

* Silence dotnet format IDE0060 warnings

* Silence dotnet format IDE0052 warnings

* Address or silence dotnet format IDE1006 warnings

* Address dotnet format CA1816 warnings

* Address or silence dotnet format CA2208 warnings

* Address or silence dotnet format CA1806 and a few CA1854 warnings

* Address dotnet format CA2211 warnings

* Address dotnet format CA1822 warnings

* Address or silence dotnet format CA1069 warnings

* Make dotnet format succeed in style mode

* Address or silence dotnet format CA2211 warnings

* Address review comments

* Address dotnet format CA2208 warnings properly

* Make ProcessResult readonly

* Address most dotnet format whitespace warnings

* Apply dotnet format whitespace formatting

A few of them have been manually reverted and the corresponding warning was silenced

* Add previously silenced warnings back

I have no clue how these disappeared

* Revert formatting changes for while and for-loops

* Format if-blocks correctly

* Run dotnet format style after rebase

* Run dotnet format whitespace after rebase

* Run dotnet format style after rebase

* Run dotnet format analyzers after rebase

* Run dotnet format after rebase and remove unused usings

- analyzers
- style
- whitespace

* Disable 'prefer switch expression' rule

* Add comments to disabled warnings

* Fix a few disabled warnings

* Fix naming rule violation, Convert shader properties to auto-property and convert values to const

* Simplify properties and array initialization, Use const when possible, Remove trailing commas

* Start working on disabled warnings

* Fix and silence a few dotnet-format warnings again

* Run dotnet format after rebase

* Use using declaration instead of block syntax

* Address IDE0251 warnings

* Address a few disabled IDE0060 warnings

* Silence IDE0060 in .editorconfig

* Revert "Simplify properties and array initialization, Use const when possible, Remove trailing commas"

This reverts commit 9462e4136c0a2100dc28b20cf9542e06790aa67e.

* dotnet format whitespace after rebase

* First dotnet format pass

* Fix naming rule violations

* Fix typo

* Add trailing commas, use targeted new and use array initializer

* Fix build issues

* Fix remaining build issues

* Remove SuppressMessage for CA1069 where possible

* Address dotnet format issues

* Address formatting issues

Co-authored-by: Ac_K <acoustik666@gmail.com>

* Add GetHashCode implementation for RenderingSurfaceInfo

* Explicitly silence CA1822 for every affected method in Syscall

* Address formatting issues in Demangler.cs

* Address review feedback

Co-authored-by: Ac_K <acoustik666@gmail.com>

* Revert marking service methods as static

* Next dotnet format pass

* Address review feedback

---------

Co-authored-by: Ac_K <acoustik666@gmail.com>
---
 src/Ryujinx.HLE/HOS/Kernel/KernelStatic.cs | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

(limited to 'src/Ryujinx.HLE/HOS/Kernel/KernelStatic.cs')

diff --git a/src/Ryujinx.HLE/HOS/Kernel/KernelStatic.cs b/src/Ryujinx.HLE/HOS/Kernel/KernelStatic.cs
index c66f4b57..2234a8c4 100644
--- a/src/Ryujinx.HLE/HOS/Kernel/KernelStatic.cs
+++ b/src/Ryujinx.HLE/HOS/Kernel/KernelStatic.cs
@@ -10,10 +10,10 @@ namespace Ryujinx.HLE.HOS.Kernel
     static class KernelStatic
     {
         [ThreadStatic]
-        private static KernelContext Context;
+        private static KernelContext _context;
 
         [ThreadStatic]
-        private static KThread CurrentThread;
+        private static KThread _currentThread;
 
         public static Result StartInitialProcess(
             KernelContext context,
@@ -22,7 +22,7 @@ namespace Ryujinx.HLE.HOS.Kernel
             int mainThreadPriority,
             ThreadStart customThreadStart)
         {
-            KProcess process = new KProcess(context);
+            KProcess process = new(context);
 
             Result result = process.Initialize(
                 creationInfo,
@@ -46,13 +46,13 @@ namespace Ryujinx.HLE.HOS.Kernel
 
         internal static void SetKernelContext(KernelContext context, KThread thread)
         {
-            Context = context;
-            CurrentThread = thread;
+            _context = context;
+            _currentThread = thread;
         }
 
         internal static KThread GetCurrentThread()
         {
-            return CurrentThread;
+            return _currentThread;
         }
 
         internal static KProcess GetCurrentProcess()
@@ -62,7 +62,7 @@ namespace Ryujinx.HLE.HOS.Kernel
 
         internal static KProcess GetProcessByPid(ulong pid)
         {
-            if (Context.Processes.TryGetValue(pid, out KProcess process))
+            if (_context.Processes.TryGetValue(pid, out KProcess process))
             {
                 return process;
             }
@@ -70,4 +70,4 @@ namespace Ryujinx.HLE.HOS.Kernel
             return null;
         }
     }
-}
\ No newline at end of file
+}
-- 
cgit v1.2.3-70-g09d2