From 1df6c07f78c4c3b8c7fc679d7466f79a10c2d496 Mon Sep 17 00:00:00 2001 From: gdkchan <gab.dark.100@gmail.com> Date: Mon, 4 Dec 2023 16:30:19 -0300 Subject: Implement support for multi-range buffers using Vulkan sparse mappings (#5427) * Pass MultiRange to BufferManager * Implement support for multi-range buffers using Vulkan sparse mappings * Use multi-range for remaining buffers, delete old methods * Assume that more buffers are contiguous * Dispose multi-range buffers after they are removed from the list * Properly init BufferBounds for constant and storage buffers * Do not try reading zero bytes data from an unmapped address on the shader cache + PR feedback * Fix misaligned sparse buffer offsets * Null check can be simplified * PR feedback --- .../Memory/BufferTextureBinding.cs | 19 ++++++------------- 1 file changed, 6 insertions(+), 13 deletions(-) (limited to 'src/Ryujinx.Graphics.Gpu/Memory/BufferTextureBinding.cs') diff --git a/src/Ryujinx.Graphics.Gpu/Memory/BufferTextureBinding.cs b/src/Ryujinx.Graphics.Gpu/Memory/BufferTextureBinding.cs index c5f0401b..bf0beffa 100644 --- a/src/Ryujinx.Graphics.Gpu/Memory/BufferTextureBinding.cs +++ b/src/Ryujinx.Graphics.Gpu/Memory/BufferTextureBinding.cs @@ -1,6 +1,7 @@ using Ryujinx.Graphics.GAL; using Ryujinx.Graphics.Gpu.Image; using Ryujinx.Graphics.Shader; +using Ryujinx.Memory.Range; namespace Ryujinx.Graphics.Gpu.Memory { @@ -20,14 +21,9 @@ namespace Ryujinx.Graphics.Gpu.Memory public ITexture Texture { get; } /// <summary> - /// The base address of the buffer binding. + /// Physical ranges of memory where the buffer texture data is located. /// </summary> - public ulong Address { get; } - - /// <summary> - /// The size of the buffer binding in bytes. - /// </summary> - public ulong Size { get; } + public MultiRange Range { get; } /// <summary> /// The image or sampler binding info for the buffer texture. @@ -49,24 +45,21 @@ namespace Ryujinx.Graphics.Gpu.Memory /// </summary> /// <param name="stage">Shader stage accessing the texture</param> /// <param name="texture">Buffer texture</param> - /// <param name="address">Base address</param> - /// <param name="size">Size in bytes</param> + /// <param name="range">Physical ranges of memory where the buffer texture data is located</param> /// <param name="bindingInfo">Binding info</param> /// <param name="format">Binding format</param> /// <param name="isImage">Whether the binding is for an image or a sampler</param> public BufferTextureBinding( ShaderStage stage, ITexture texture, - ulong address, - ulong size, + MultiRange range, TextureBindingInfo bindingInfo, Format format, bool isImage) { Stage = stage; Texture = texture; - Address = address; - Size = size; + Range = range; BindingInfo = bindingInfo; Format = format; IsImage = isImage; -- cgit v1.2.3-70-g09d2