From 1df6c07f78c4c3b8c7fc679d7466f79a10c2d496 Mon Sep 17 00:00:00 2001
From: gdkchan <gab.dark.100@gmail.com>
Date: Mon, 4 Dec 2023 16:30:19 -0300
Subject: Implement support for multi-range buffers using Vulkan sparse
mappings (#5427)
* Pass MultiRange to BufferManager
* Implement support for multi-range buffers using Vulkan sparse mappings
* Use multi-range for remaining buffers, delete old methods
* Assume that more buffers are contiguous
* Dispose multi-range buffers after they are removed from the list
* Properly init BufferBounds for constant and storage buffers
* Do not try reading zero bytes data from an unmapped address on the shader cache + PR feedback
* Fix misaligned sparse buffer offsets
* Null check can be simplified
* PR feedback
---
src/Ryujinx.Graphics.Gpu/Memory/BufferBounds.cs | 21 ++++++++++-----------
1 file changed, 10 insertions(+), 11 deletions(-)
(limited to 'src/Ryujinx.Graphics.Gpu/Memory/BufferBounds.cs')
diff --git a/src/Ryujinx.Graphics.Gpu/Memory/BufferBounds.cs b/src/Ryujinx.Graphics.Gpu/Memory/BufferBounds.cs
index a9ea04ce..aed3268a 100644
--- a/src/Ryujinx.Graphics.Gpu/Memory/BufferBounds.cs
+++ b/src/Ryujinx.Graphics.Gpu/Memory/BufferBounds.cs
@@ -1,4 +1,5 @@
using Ryujinx.Graphics.Shader;
+using Ryujinx.Memory.Range;
namespace Ryujinx.Graphics.Gpu.Memory
{
@@ -8,30 +9,28 @@ namespace Ryujinx.Graphics.Gpu.Memory
readonly struct BufferBounds
{
/// <summary>
- /// Region virtual address.
+ /// Physical memory ranges where the buffer is mapped.
/// </summary>
- public ulong Address { get; }
+ public MultiRange Range { get; }
/// <summary>
- /// Region size in bytes.
+ /// Buffer usage flags.
/// </summary>
- public ulong Size { get; }
+ public BufferUsageFlags Flags { get; }
/// <summary>
- /// Buffer usage flags.
+ /// Indicates that the backing memory for the buffer does not exist.
/// </summary>
- public BufferUsageFlags Flags { get; }
+ public bool IsUnmapped => Range.IsUnmapped;
/// <summary>
/// Creates a new buffer region.
/// </summary>
- /// <param name="address">Region address</param>
- /// <param name="size">Region size</param>
+ /// <param name="range">Physical memory ranges where the buffer is mapped</param>
/// <param name="flags">Buffer usage flags</param>
- public BufferBounds(ulong address, ulong size, BufferUsageFlags flags = BufferUsageFlags.None)
+ public BufferBounds(MultiRange range, BufferUsageFlags flags = BufferUsageFlags.None)
{
- Address = address;
- Size = size;
+ Range = range;
Flags = flags;
}
}
--
cgit v1.2.3-70-g09d2