From 305f06eb71a7832e6b0081a67015b66ced8a23cd Mon Sep 17 00:00:00 2001
From: Mary <me@thog.eu>
Date: Sat, 24 Apr 2021 12:16:01 +0200
Subject: HLE: Fix integer sign inconcistency accross the codebase (#2222)
* Make all title id instances unsigned
* Replace address and size with ulong instead of signed types
Long overdue change.
Also change some logics here and there to optimize with the new memory
manager.
* Address Ac_K's comments
* Remove uneeded cast all around
* Fixes some others misalignment
---
Ryujinx.HLE/Utilities/StringUtils.cs | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
(limited to 'Ryujinx.HLE/Utilities/StringUtils.cs')
diff --git a/Ryujinx.HLE/Utilities/StringUtils.cs b/Ryujinx.HLE/Utilities/StringUtils.cs
index 4399da21..0259a4fd 100644
--- a/Ryujinx.HLE/Utilities/StringUtils.cs
+++ b/Ryujinx.HLE/Utilities/StringUtils.cs
@@ -53,14 +53,14 @@ namespace Ryujinx.HLE.Utilities
public static string ReadUtf8String(ServiceCtx context, int index = 0)
{
- long position = context.Request.PtrBuff[index].Position;
- long size = context.Request.PtrBuff[index].Size;
+ ulong position = context.Request.PtrBuff[index].Position;
+ ulong size = context.Request.PtrBuff[index].Size;
using (MemoryStream ms = new MemoryStream())
{
while (size-- > 0)
{
- byte value = context.Memory.Read<byte>((ulong)position++);
+ byte value = context.Memory.Read<byte>(position++);
if (value == 0)
{
@@ -86,8 +86,8 @@ namespace Ryujinx.HLE.Utilities
public static string ReadUtf8StringSend(ServiceCtx context, int index = 0)
{
- long position = context.Request.SendBuff[index].Position;
- long size = context.Request.SendBuff[index].Size;
+ ulong position = context.Request.SendBuff[index].Position;
+ ulong size = context.Request.SendBuff[index].Size;
using (MemoryStream ms = new MemoryStream())
{
--
cgit v1.2.3-70-g09d2