From 305f06eb71a7832e6b0081a67015b66ced8a23cd Mon Sep 17 00:00:00 2001
From: Mary <me@thog.eu>
Date: Sat, 24 Apr 2021 12:16:01 +0200
Subject: HLE: Fix integer sign inconcistency accross the codebase (#2222)
* Make all title id instances unsigned
* Replace address and size with ulong instead of signed types
Long overdue change.
Also change some logics here and there to optimize with the new memory
manager.
* Address Ac_K's comments
* Remove uneeded cast all around
* Fixes some others misalignment
---
Ryujinx.HLE/HOS/Services/ServerBase.cs | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
(limited to 'Ryujinx.HLE/HOS/Services/ServerBase.cs')
diff --git a/Ryujinx.HLE/HOS/Services/ServerBase.cs b/Ryujinx.HLE/HOS/Services/ServerBase.cs
index bf638800..f957a624 100644
--- a/Ryujinx.HLE/HOS/Services/ServerBase.cs
+++ b/Ryujinx.HLE/HOS/Services/ServerBase.cs
@@ -180,13 +180,13 @@ namespace Ryujinx.HLE.HOS.Services
{
for (int i = 0; i < request.RecvListBuff.Count; i++)
{
- int size = BinaryPrimitives.ReadInt16LittleEndian(request.RawData.AsSpan().Slice(sizesOffset + i * 2, 2));
+ ulong size = (ulong)BinaryPrimitives.ReadInt16LittleEndian(request.RawData.AsSpan().Slice(sizesOffset + i * 2, 2));
- response.PtrBuff.Add(new IpcPtrBuffDesc((long)tempAddr, i, size));
+ response.PtrBuff.Add(new IpcPtrBuffDesc(tempAddr, (uint)i, size));
- request.RecvListBuff[i] = new IpcRecvListBuffDesc((long)tempAddr, size);
+ request.RecvListBuff[i] = new IpcRecvListBuffDesc(tempAddr, size);
- tempAddr += (ulong)size;
+ tempAddr += size;
}
}
--
cgit v1.2.3-70-g09d2