From a33dc2f4919f7fdc8ea9db41c4c70c38cedfd3df Mon Sep 17 00:00:00 2001 From: mageven <62494521+mageven@users.noreply.github.com> Date: Tue, 4 Aug 2020 05:02:53 +0530 Subject: Improved Logger (#1292) * Logger class changes only Now compile-time checking is possible with the help of Nullable Value types. * Misc formatting * Manual optimizations PrintGuestLog PrintGuestStackTrace Surfaceflinger DequeueBuffer * Reduce SendVibrationXX log level to Debug * Add Notice log level This level is always enabled and used to print system info, etc... Also, rewrite LogColor to switch expression as colors are static * Unify unhandled exception event handlers * Print enabled LogLevels during init * Re-add App Exit disposes in proper order nit: switch case spacing * Revert PrintGuestStackTrace to Info logs due to #1407 PrintGuestStackTrace is now called in some critical error handlers so revert to old behavior as KThread isn't part of Guest. * Batch replace Logger statements --- Ryujinx.HLE/HOS/Kernel/Threading/KThread.cs | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) (limited to 'Ryujinx.HLE/HOS/Kernel/Threading/KThread.cs') diff --git a/Ryujinx.HLE/HOS/Kernel/Threading/KThread.cs b/Ryujinx.HLE/HOS/Kernel/Threading/KThread.cs index d4603178..86887367 100644 --- a/Ryujinx.HLE/HOS/Kernel/Threading/KThread.cs +++ b/Ryujinx.HLE/HOS/Kernel/Threading/KThread.cs @@ -1131,12 +1131,7 @@ namespace Ryujinx.HLE.HOS.Kernel.Threading public void PrintGuestStackTrace() { - StringBuilder trace = new StringBuilder(); - - trace.AppendLine("Guest stack trace:"); - trace.AppendLine(GetGuestStackTrace()); - - Logger.PrintInfo(LogClass.Cpu, trace.ToString()); + Logger.Info?.Print(LogClass.Cpu, $"Guest stack trace:\n{GetGuestStackTrace()}\n"); } public void Execute() -- cgit v1.2.3-70-g09d2