1 files changed, 70 insertions, 72 deletions
diff --git a/src/Ryujinx.HLE/HOS/Ipc/IpcMessage.cs b/src/Ryujinx.HLE/HOS/Ipc/IpcMessage.cs
index 21630c42..feba09fe 100644
--- a/src/Ryujinx.HLE/HOS/Ipc/IpcMessage.cs
+++ b/src/Ryujinx.HLE/HOS/Ipc/IpcMessage.cs
@@ -2,7 +2,6 @@ using Microsoft.IO;
 using Ryujinx.Common;
 using Ryujinx.Common.Memory;
 using System;
-using System.Buffers;
 using System.Collections.Generic;
 using System.Diagnostics;
 using System.IO;
@@ -15,10 +14,10 @@ namespace Ryujinx.HLE.HOS.Ipc
 
         public IpcHandleDesc HandleDesc { get; set; }
 
-        public List<IpcPtrBuffDesc>      PtrBuff      { get; private set; }
-        public List<IpcBuffDesc>         SendBuff     { get; private set; }
-        public List<IpcBuffDesc>         ReceiveBuff  { get; private set; }
-        public List<IpcBuffDesc>         ExchangeBuff { get; private set; }
+        public List<IpcPtrBuffDesc> PtrBuff { get; private set; }
+        public List<IpcBuffDesc> SendBuff { get; private set; }
+        public List<IpcBuffDesc> ReceiveBuff { get; private set; }
+        public List<IpcBuffDesc> ExchangeBuff { get; private set; }
         public List<IpcRecvListBuffDesc> RecvListBuff { get; private set; }
 
         public List<int> ObjectIds { get; private set; }
@@ -27,9 +26,9 @@ namespace Ryujinx.HLE.HOS.Ipc
 
         public IpcMessage()
         {
-            PtrBuff      = new List<IpcPtrBuffDesc>(0);
-            SendBuff     = new List<IpcBuffDesc>(0);
-            ReceiveBuff  = new List<IpcBuffDesc>(0);
+            PtrBuff = new List<IpcPtrBuffDesc>(0);
+            SendBuff = new List<IpcBuffDesc>(0);
+            ReceiveBuff = new List<IpcBuffDesc>(0);
             ExchangeBuff = new List<IpcBuffDesc>(0);
             RecvListBuff = new List<IpcRecvListBuffDesc>(0);
 
@@ -38,93 +37,92 @@ namespace Ryujinx.HLE.HOS.Ipc
 
         public IpcMessage(ReadOnlySpan<byte> data, long cmdPtr)
         {
-            using (RecyclableMemoryStream ms = MemoryStreamManager.Shared.GetStream(data))
-            {
-                BinaryReader reader = new BinaryReader(ms);
+            using RecyclableMemoryStream ms = MemoryStreamManager.Shared.GetStream(data);
 
-                int word0 = reader.ReadInt32();
-                int word1 = reader.ReadInt32();
+            BinaryReader reader = new(ms);
 
-                Type = (IpcMessageType)(word0 & 0xffff);
+            int word0 = reader.ReadInt32();
+            int word1 = reader.ReadInt32();
 
-                int  ptrBuffCount  = (word0 >> 16) & 0xf;
-                int  sendBuffCount = (word0 >> 20) & 0xf;
-                int  recvBuffCount = (word0 >> 24) & 0xf;
-                int  xchgBuffCount = (word0 >> 28) & 0xf;
+            Type = (IpcMessageType)(word0 & 0xffff);
 
-                int  rawDataSize   = (word1 >> 0) & 0x3ff;
-                int  recvListFlags = (word1 >> 10) & 0xf;
-                bool hndDescEnable = ((word1 >> 31) & 0x1) != 0;
+            int ptrBuffCount = (word0 >> 16) & 0xf;
+            int sendBuffCount = (word0 >> 20) & 0xf;
+            int recvBuffCount = (word0 >> 24) & 0xf;
+            int xchgBuffCount = (word0 >> 28) & 0xf;
 
-                if (hndDescEnable)
-                {
-                    HandleDesc = new IpcHandleDesc(reader);
-                }
+            int rawDataSize = (word1 >> 0) & 0x3ff;
+            int recvListFlags = (word1 >> 10) & 0xf;
+            bool hndDescEnable = ((word1 >> 31) & 0x1) != 0;
 
-                PtrBuff = new List<IpcPtrBuffDesc>(ptrBuffCount);
+            if (hndDescEnable)
+            {
+                HandleDesc = new IpcHandleDesc(reader);
+            }
 
-                for (int index = 0; index < ptrBuffCount; index++)
-                {
-                    PtrBuff.Add(new IpcPtrBuffDesc(reader));
-                }
+            PtrBuff = new List<IpcPtrBuffDesc>(ptrBuffCount);
 
-                static List<IpcBuffDesc> ReadBuff(BinaryReader reader, int count)
+            for (int index = 0; index < ptrBuffCount; index++)
+            {
+                PtrBuff.Add(new IpcPtrBuffDesc(reader));
+            }
+
+            static List<IpcBuffDesc> ReadBuff(BinaryReader reader, int count)
+            {
+                List<IpcBuffDesc> buff = new(count);
+
+                for (int index = 0; index < count; index++)
                 {
-                    List<IpcBuffDesc> buff = new List<IpcBuffDesc>(count);
-                    
-                    for (int index = 0; index < count; index++)
-                    {
-                        buff.Add(new IpcBuffDesc(reader));
-                    }
-                    
-                    return buff;
+                    buff.Add(new IpcBuffDesc(reader));
                 }
 
-                SendBuff = ReadBuff(reader, sendBuffCount);
-                ReceiveBuff = ReadBuff(reader, recvBuffCount);
-                ExchangeBuff = ReadBuff(reader, xchgBuffCount);
+                return buff;
+            }
+
+            SendBuff = ReadBuff(reader, sendBuffCount);
+            ReceiveBuff = ReadBuff(reader, recvBuffCount);
+            ExchangeBuff = ReadBuff(reader, xchgBuffCount);
 
-                rawDataSize *= 4;
+            rawDataSize *= 4;
 
-                long recvListPos = reader.BaseStream.Position + rawDataSize;
+            long recvListPos = reader.BaseStream.Position + rawDataSize;
 
             // Only CMIF has the padding requirements.
             if (Type < IpcMessageType.TipcCloseSession)
             {
                 long pad0 = GetPadSize16(reader.BaseStream.Position + cmdPtr);
 
-                    if (rawDataSize != 0)
-                    {
-                        rawDataSize -= (int)pad0;
-                    }
-
-                    reader.BaseStream.Seek(pad0, SeekOrigin.Current);
+                if (rawDataSize != 0)
+                {
+                    rawDataSize -= (int)pad0;
                 }
 
-                int recvListCount = recvListFlags - 2;
+                reader.BaseStream.Seek(pad0, SeekOrigin.Current);
+            }
 
-                if (recvListCount == 0)
-                {
-                    recvListCount = 1;
-                }
-                else if (recvListCount < 0)
-                {
-                    recvListCount = 0;
-                }
+            int recvListCount = recvListFlags - 2;
 
-                RawData = reader.ReadBytes(rawDataSize);
+            if (recvListCount == 0)
+            {
+                recvListCount = 1;
+            }
+            else if (recvListCount < 0)
+            {
+                recvListCount = 0;
+            }
 
-                reader.BaseStream.Seek(recvListPos, SeekOrigin.Begin);
+            RawData = reader.ReadBytes(rawDataSize);
 
-                RecvListBuff = new List<IpcRecvListBuffDesc>(recvListCount);
+            reader.BaseStream.Seek(recvListPos, SeekOrigin.Begin);
 
-                for (int index = 0; index < recvListCount; index++)
-                {
-                    RecvListBuff.Add(new IpcRecvListBuffDesc(reader.ReadUInt64()));
-                }
+            RecvListBuff = new List<IpcRecvListBuffDesc>(recvListCount);
 
-                ObjectIds = new List<int>(0);
+            for (int index = 0; index < recvListCount; index++)
+            {
+                RecvListBuff.Add(new IpcRecvListBuffDesc(reader.ReadUInt64()));
             }
+
+            ObjectIds = new List<int>(0);
         }
 
         public RecyclableMemoryStream GetStream(long cmdPtr, ulong recvListAddr)
@@ -134,10 +132,10 @@ namespace Ryujinx.HLE.HOS.Ipc
             int word0;
             int word1;
 
-            word0  = (int)Type;
-            word0 |= (PtrBuff.Count      & 0xf) << 16;
-            word0 |= (SendBuff.Count     & 0xf) << 20;
-            word0 |= (ReceiveBuff.Count  & 0xf) << 24;
+            word0 = (int)Type;
+            word0 |= (PtrBuff.Count & 0xf) << 16;
+            word0 |= (SendBuff.Count & 0xf) << 20;
+            word0 |= (ReceiveBuff.Count & 0xf) << 24;
             word0 |= (ExchangeBuff.Count & 0xf) << 28;
 
             using RecyclableMemoryStream handleDataStream = HandleDesc?.GetStream();
@@ -238,7 +236,7 @@ namespace Ryujinx.HLE.HOS.Ipc
             return ms;
         }
 
-        private long GetPadSize16(long position)
+        private static long GetPadSize16(long position)
         {
             if ((position & 0xf) != 0)
             {