aboutsummaryrefslogtreecommitdiff
path: root/src/Ryujinx.Graphics.Vulkan/DescriptorSetUpdater.cs
diff options
context:
space:
mode:
Diffstat (limited to 'src/Ryujinx.Graphics.Vulkan/DescriptorSetUpdater.cs')
-rw-r--r--src/Ryujinx.Graphics.Vulkan/DescriptorSetUpdater.cs215
1 files changed, 96 insertions, 119 deletions
diff --git a/src/Ryujinx.Graphics.Vulkan/DescriptorSetUpdater.cs b/src/Ryujinx.Graphics.Vulkan/DescriptorSetUpdater.cs
index a47ea5ff..f3ac36e1 100644
--- a/src/Ryujinx.Graphics.Vulkan/DescriptorSetUpdater.cs
+++ b/src/Ryujinx.Graphics.Vulkan/DescriptorSetUpdater.cs
@@ -372,8 +372,9 @@ namespace Ryujinx.Graphics.Vulkan
private void UpdateAndBind(CommandBufferScoped cbs, int setIndex, PipelineBindPoint pbp)
{
var program = _program;
- int stagesCount = program.Bindings[setIndex].Length;
- if (stagesCount == 0 && setIndex != PipelineBase.UniformSetIndex)
+ var bindingSegments = program.BindingSegments[setIndex];
+
+ if (bindingSegments.Length == 0 && setIndex != PipelineBase.UniformSetIndex)
{
return;
}
@@ -410,125 +411,113 @@ namespace Ryujinx.Graphics.Vulkan
}
}
- for (int stageIndex = 0; stageIndex < stagesCount; stageIndex++)
+ foreach (ResourceBindingSegment segment in bindingSegments)
{
- var stageBindings = program.Bindings[setIndex][stageIndex];
- int bindingsCount = stageBindings.Length;
- int count;
+ int binding = segment.Binding;
+ int count = segment.Count;
- for (int bindingIndex = 0; bindingIndex < bindingsCount; bindingIndex += count)
+ if (setIndex == PipelineBase.UniformSetIndex)
{
- int binding = stageBindings[bindingIndex];
- count = 1;
-
- while (bindingIndex + count < bindingsCount && stageBindings[bindingIndex + count] == binding + count)
+ for (int i = 0; i < count; i++)
{
- count++;
- }
+ int index = binding + i;
- if (setIndex == PipelineBase.UniformSetIndex)
- {
- for (int i = 0; i < count; i++)
+ if (!_uniformSet[index])
{
- int index = binding + i;
-
- if (!_uniformSet[index])
- {
- UpdateBuffer(cbs, ref _uniformBuffers[index], _uniformBufferRefs[index], dummyBuffer);
+ UpdateBuffer(cbs, ref _uniformBuffers[index], _uniformBufferRefs[index], dummyBuffer);
- _uniformSet[index] = true;
- }
+ _uniformSet[index] = true;
}
-
- ReadOnlySpan<DescriptorBufferInfo> uniformBuffers = _uniformBuffers;
- dsc.UpdateBuffers(0, binding, uniformBuffers.Slice(binding, count), DescriptorType.UniformBuffer);
}
- else if (setIndex == PipelineBase.StorageSetIndex)
+
+ ReadOnlySpan<DescriptorBufferInfo> uniformBuffers = _uniformBuffers;
+ dsc.UpdateBuffers(0, binding, uniformBuffers.Slice(binding, count), DescriptorType.UniformBuffer);
+ }
+ else if (setIndex == PipelineBase.StorageSetIndex)
+ {
+ for (int i = 0; i < count; i++)
{
- for (int i = 0; i < count; i++)
- {
- int index = binding + i;
+ int index = binding + i;
- if (!_storageSet[index])
- {
- UpdateBuffer(cbs, ref _storageBuffers[index], _storageBufferRefs[index], dummyBuffer);
+ if (!_storageSet[index])
+ {
+ UpdateBuffer(cbs, ref _storageBuffers[index], _storageBufferRefs[index], dummyBuffer);
- _storageSet[index] = true;
- }
+ _storageSet[index] = true;
}
+ }
- ReadOnlySpan<DescriptorBufferInfo> storageBuffers = _storageBuffers;
- if (program.HasMinimalLayout)
- {
- dsc.UpdateBuffers(0, binding, storageBuffers.Slice(binding, count), DescriptorType.StorageBuffer);
- }
- else
- {
- dsc.UpdateStorageBuffers(0, binding, storageBuffers.Slice(binding, count));
- }
+ ReadOnlySpan<DescriptorBufferInfo> storageBuffers = _storageBuffers;
+ if (program.HasMinimalLayout)
+ {
+ dsc.UpdateBuffers(0, binding, storageBuffers.Slice(binding, count), DescriptorType.StorageBuffer);
}
- else if (setIndex == PipelineBase.TextureSetIndex)
+ else
{
- if (((uint)binding % (Constants.MaxTexturesPerStage * 2)) < Constants.MaxTexturesPerStage || program.HasMinimalLayout)
- {
- Span<DescriptorImageInfo> textures = _textures;
-
- for (int i = 0; i < count; i++)
- {
- ref var texture = ref textures[i];
+ dsc.UpdateStorageBuffers(0, binding, storageBuffers.Slice(binding, count));
+ }
+ }
+ else if (setIndex == PipelineBase.TextureSetIndex)
+ {
+ if (segment.Type != ResourceType.BufferTexture)
+ {
+ Span<DescriptorImageInfo> textures = _textures;
- texture.ImageView = _textureRefs[binding + i]?.Get(cbs).Value ?? default;
- texture.Sampler = _samplerRefs[binding + i]?.Get(cbs).Value ?? default;
+ for (int i = 0; i < count; i++)
+ {
+ ref var texture = ref textures[i];
- if (texture.ImageView.Handle == 0)
- {
- texture.ImageView = _dummyTexture.GetImageView().Get(cbs).Value;
- }
+ texture.ImageView = _textureRefs[binding + i]?.Get(cbs).Value ?? default;
+ texture.Sampler = _samplerRefs[binding + i]?.Get(cbs).Value ?? default;
- if (texture.Sampler.Handle == 0)
- {
- texture.Sampler = _dummySampler.GetSampler().Get(cbs).Value;
- }
+ if (texture.ImageView.Handle == 0)
+ {
+ texture.ImageView = _dummyTexture.GetImageView().Get(cbs).Value;
}
- dsc.UpdateImages(0, binding, textures.Slice(0, count), DescriptorType.CombinedImageSampler);
- }
- else
- {
- Span<BufferView> bufferTextures = _bufferTextures;
-
- for (int i = 0; i < count; i++)
+ if (texture.Sampler.Handle == 0)
{
- bufferTextures[i] = _bufferTextureRefs[binding + i]?.GetBufferView(cbs) ?? default;
+ texture.Sampler = _dummySampler.GetSampler().Get(cbs).Value;
}
-
- dsc.UpdateBufferImages(0, binding, bufferTextures.Slice(0, count), DescriptorType.UniformTexelBuffer);
}
+
+ dsc.UpdateImages(0, binding, textures.Slice(0, count), DescriptorType.CombinedImageSampler);
}
- else if (setIndex == PipelineBase.ImageSetIndex)
+ else
{
- if (((uint)binding % (Constants.MaxImagesPerStage * 2)) < Constants.MaxImagesPerStage || program.HasMinimalLayout)
+ Span<BufferView> bufferTextures = _bufferTextures;
+
+ for (int i = 0; i < count; i++)
{
- Span<DescriptorImageInfo> images = _images;
+ bufferTextures[i] = _bufferTextureRefs[binding + i]?.GetBufferView(cbs) ?? default;
+ }
- for (int i = 0; i < count; i++)
- {
- images[i].ImageView = _imageRefs[binding + i]?.Get(cbs).Value ?? default;
- }
+ dsc.UpdateBufferImages(0, binding, bufferTextures.Slice(0, count), DescriptorType.UniformTexelBuffer);
+ }
+ }
+ else if (setIndex == PipelineBase.ImageSetIndex)
+ {
+ if (segment.Type != ResourceType.BufferImage)
+ {
+ Span<DescriptorImageInfo> images = _images;
- dsc.UpdateImages(0, binding, images.Slice(0, count), DescriptorType.StorageImage);
- }
- else
+ for (int i = 0; i < count; i++)
{
- Span<BufferView> bufferImages = _bufferImages;
+ images[i].ImageView = _imageRefs[binding + i]?.Get(cbs).Value ?? default;
+ }
- for (int i = 0; i < count; i++)
- {
- bufferImages[i] = _bufferImageRefs[binding + i]?.GetBufferView(cbs, _bufferImageFormats[binding + i]) ?? default;
- }
+ dsc.UpdateImages(0, binding, images.Slice(0, count), DescriptorType.StorageImage);
+ }
+ else
+ {
+ Span<BufferView> bufferImages = _bufferImages;
- dsc.UpdateBufferImages(0, binding, bufferImages.Slice(0, count), DescriptorType.StorageTexelBuffer);
+ for (int i = 0; i < count; i++)
+ {
+ bufferImages[i] = _bufferImageRefs[binding + i]?.GetBufferView(cbs, _bufferImageFormats[binding + i]) ?? default;
}
+
+ dsc.UpdateBufferImages(0, binding, bufferImages.Slice(0, count), DescriptorType.StorageTexelBuffer);
}
}
}
@@ -568,9 +557,6 @@ namespace Ryujinx.Graphics.Vulkan
[MethodImpl(MethodImplOptions.AggressiveInlining)]
private void UpdateAndBindUniformBufferPd(CommandBufferScoped cbs, PipelineBindPoint pbp)
{
- var dummyBuffer = _dummyBuffer?.GetBuffer();
- int stagesCount = _program.Bindings[PipelineBase.UniformSetIndex].Length;
-
if (!_uniformSet[0])
{
Span<DescriptorBufferInfo> uniformBuffer = stackalloc DescriptorBufferInfo[1];
@@ -587,41 +573,32 @@ namespace Ryujinx.Graphics.Vulkan
UpdateBuffers(cbs, pbp, 0, uniformBuffer, DescriptorType.UniformBuffer);
}
- for (int stageIndex = 0; stageIndex < stagesCount; stageIndex++)
+ var bindingSegments = _program.BindingSegments[PipelineBase.UniformSetIndex];
+ var dummyBuffer = _dummyBuffer?.GetBuffer();
+
+ foreach (ResourceBindingSegment segment in bindingSegments)
{
- var stageBindings = _program.Bindings[PipelineBase.UniformSetIndex][stageIndex];
- int bindingsCount = stageBindings.Length;
- int count;
+ int binding = segment.Binding;
+ int count = segment.Count;
+
+ bool doUpdate = false;
- for (int bindingIndex = 0; bindingIndex < bindingsCount; bindingIndex += count)
+ for (int i = 0; i < count; i++)
{
- int binding = stageBindings[bindingIndex];
- count = 1;
+ int index = binding + i;
- while (bindingIndex + count < bindingsCount && stageBindings[bindingIndex + count] == binding + count)
+ if (!_uniformSet[index])
{
- count++;
- }
-
- bool doUpdate = false;
-
- for (int i = 0; i < count; i++)
- {
- int index = binding + i;
-
- if (!_uniformSet[index])
- {
- UpdateBuffer(cbs, ref _uniformBuffers[index], _uniformBufferRefs[index], dummyBuffer);
- _uniformSet[index] = true;
- doUpdate = true;
- }
+ UpdateBuffer(cbs, ref _uniformBuffers[index], _uniformBufferRefs[index], dummyBuffer);
+ _uniformSet[index] = true;
+ doUpdate = true;
}
+ }
- if (doUpdate)
- {
- ReadOnlySpan<DescriptorBufferInfo> uniformBuffers = _uniformBuffers;
- UpdateBuffers(cbs, pbp, binding, uniformBuffers.Slice(binding, count), DescriptorType.UniformBuffer);
- }
+ if (doUpdate)
+ {
+ ReadOnlySpan<DescriptorBufferInfo> uniformBuffers = _uniformBuffers;
+ UpdateBuffers(cbs, pbp, binding, uniformBuffers.Slice(binding, count), DescriptorType.UniformBuffer);
}
}
}