diff options
| author | Marco Carvalho <marcolucio27@gmail.com> | 2023-10-05 07:41:00 -0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-10-05 12:41:00 +0200 |
| commit | 7835968214241c37c677b6c5c82aa3353546de89 (patch) | |
| tree | 70e4a1d5fbacf371d1d5eff1d6c025b7ff14f922 /src/Ryujinx.HLE/HOS/Kernel/Process/HleProcessDebugger.cs | |
| parent | 0aceb534cb34287e354f92c37a1b5ebf136e8e74 (diff) | |
Strings should not be concatenated using '+' in a loop (#5664)1.1.1043
* Strings should not be concatenated using '+' in a loop
* fix IDE0090
* undo GenerateLoadOrStore
* prefer string interpolation
* Update src/Ryujinx.Graphics.Shader/CodeGen/Glsl/Instructions/InstGen.cs
Co-authored-by: Mary <thog@protonmail.com>
---------
Co-authored-by: Mary <thog@protonmail.com>
Diffstat (limited to 'src/Ryujinx.HLE/HOS/Kernel/Process/HleProcessDebugger.cs')
| -rw-r--r-- | src/Ryujinx.HLE/HOS/Kernel/Process/HleProcessDebugger.cs | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/src/Ryujinx.HLE/HOS/Kernel/Process/HleProcessDebugger.cs b/src/Ryujinx.HLE/HOS/Kernel/Process/HleProcessDebugger.cs index cbfef588..7578f1d2 100644 --- a/src/Ryujinx.HLE/HOS/Kernel/Process/HleProcessDebugger.cs +++ b/src/Ryujinx.HLE/HOS/Kernel/Process/HleProcessDebugger.cs @@ -436,14 +436,14 @@ namespace Ryujinx.HLE.HOS.Kernel.Process uint nameIndex = sym.NameOffset; - string name = string.Empty; + StringBuilder nameBuilder = new(); for (int chr; (chr = memory.Read<byte>(strTblAddr + nameIndex++)) != 0;) { - name += (char)chr; + nameBuilder.Append((char)chr); } - return new ElfSymbol(name, sym.Info, sym.Other, sym.SectionIndex, sym.ValueAddress, sym.Size); + return new ElfSymbol(nameBuilder.ToString(), sym.Info, sym.Other, sym.SectionIndex, sym.ValueAddress, sym.Size); } private static ElfSymbol GetSymbol32(IVirtualMemoryManager memory, ulong address, ulong strTblAddr) @@ -452,14 +452,14 @@ namespace Ryujinx.HLE.HOS.Kernel.Process uint nameIndex = sym.NameOffset; - string name = string.Empty; + StringBuilder nameBuilder = new(); for (int chr; (chr = memory.Read<byte>(strTblAddr + nameIndex++)) != 0;) { - name += (char)chr; + nameBuilder.Append((char)chr); } - return new ElfSymbol(name, sym.Info, sym.Other, sym.SectionIndex, sym.ValueAddress, sym.Size); + return new ElfSymbol(nameBuilder.ToString(), sym.Info, sym.Other, sym.SectionIndex, sym.ValueAddress, sym.Size); } } } |