Reduce JIT GC allocations (#2515)

* Turn `MemoryOperand` into a struct * Remove `IntrinsicOperation` * Remove `PhiNode` * Remove `Node` * Turn `Operand` into a struct * Turn `Operation` into a struct * Clean up pool management methods * Add `Arena` allocator * Move `OperationHelper` to `Operation.Factory` * Move `OperandHelper` to `Operand.Factory` * Optimize `Operation` a bit * Fix `Arena` initialization * Rename `NativeList<T>` to `ArenaList<T>` * Reduce `Operand` size from 88 to 56 bytes * Reduce `Operation` size from 56 to 40 bytes * Add optimistic interning of Register & Constant operands * Optimize `RegisterUsage` pass a bit * Optimize `RemoveUnusedNodes` pass a bit Iterating in reverse-order allows killing dependency chains in a single pass. * Fix PPTC symbols * Optimize `BasicBlock` a bit Reduce allocations from `_successor` & `DominanceFrontiers` * Fix `Operation` resize * Make `Arena` expandable Change the arena allocator to be expandable by allocating in pages, with some of them being pooled. Currently 32 pages are pooled. An LRU removal mechanism should probably be added to it. Apparently MHR can allocate bitmaps large enough to exceed the 16MB limit for the type. * Move `Arena` & `ArenaList` to `Common` * Remove `ThreadStaticPool` & co * Add `PhiOperation` * Reduce `Operand` size from 56 from 48 bytes * Add linear-probing to `Operand` intern table * Optimize `HybridAllocator` a bit * Add `Allocators` class * Tune `ArenaAllocator` sizes * Add page removal mechanism to `ArenaAllocator` Remove pages which have not been used for more than 5s after each reset. I am on fence if this would be better using a Gen2 callback object like the one in System.Buffers.ArrayPool<T>, to trim the pool. Because right now if a large translation happens, the pages will be freed only after a reset. This reset may not happen for a while because no new translation is hit, but the arena base sizes are rather small. * Fix `OOM` when allocating larger than page size in `ArenaAllocator` Tweak resizing mechanism for Operand.Uses and Assignemnts. * Optimize `Optimizer` a bit * Optimize `Operand.Add<T>/Remove<T>` a bit * Clean up `PreAllocator` * Fix phi insertion order Reduce codegen diffs. * Fix code alignment * Use new heuristics for degree of parallelism * Suppress warnings * Address gdkchan's feedback Renamed `GetValue()` to `GetValueUnsafe()` to make it more clear that `Operand.Value` should usually not be modified directly. * Add fast path to `ArenaAllocator` * Assembly for `ArenaAllocator.Allocate(ulong)`: .L0: mov rax, [rcx+0x18] lea r8, [rax+rdx] cmp r8, [rcx+0x10] ja short .L2 .L1: mov rdx, [rcx+8] add rax, [rdx+8] mov [rcx+0x18], r8 ret .L2: jmp ArenaAllocator.AllocateSlow(UInt64) A few variable/field had to be changed to ulong so that RyuJIT avoids emitting zero-extends. * Implement a new heuristic to free pooled pages. If an arena is used often, it is more likely that its pages will be needed, so the pages are kept for longer (e.g: during PPTC rebuild or burst sof compilations). If is not used often, then it is more likely that its pages will not be needed (e.g: after PPTC rebuild or bursts of compilations). * Address riperiperi's feedback * Use `EqualityComparer<T>` in `IntrusiveList<T>` Avoids a potential GC hole in `Equals(T, T)`.
author: FICTURE7 <FICTURE7@gmail.com> 2021-08-17 22:08:34 +0400
committer: GitHub <noreply@github.com> 2021-08-17 15:08:34 -0300
commit: 22b2cb39af00fb8881e908fd671fbf57a6e2db2a (patch)
tree: a79e2df801d7f16a33ff50b3c5bfed303cb476e9 /ARMeilleure/Common/ThreadStaticPool.cs
parent: cd4530f29c6a4ffd1b023105350b0440fa63f47b (diff)
1 files changed, 0 insertions, 219 deletions
diff --git a/ARMeilleure/Common/ThreadStaticPool.cs b/ARMeilleure/Common/ThreadStaticPool.cs
deleted file mode 100644
index bbe662f8..00000000
--- a/ARMeilleure/Common/ThreadStaticPool.cs
+++ /dev/null
@@ -1,219 +0,0 @@
-using ARMeilleure.Translation.PTC;
-using System;
-using System.Collections.Concurrent;
-using System.Collections.Generic;
-
-namespace ARMeilleure.Common
-{
-    class ThreadStaticPool<T> where T : class, new()
-    {
-        [ThreadStatic]
-        private static ThreadStaticPool<T> _instance;
-
-        public static ThreadStaticPool<T> Instance
-        {
-            get
-            {
-                if (_instance == null)
-                {
-                    PreparePool(); // So that we can still use a pool when blindly initializing one.
-                }
-
-                return _instance;
-            }
-        }
-
-        private static readonly ConcurrentDictionary<int, Stack<ThreadStaticPool<T>>> _pools = new();
-
-        private static Stack<ThreadStaticPool<T>> GetPools(int groupId)
-        {
-            return _pools.GetOrAdd(groupId, (groupId) => new());
-        }
-
-        public static void PreparePool(
-            int groupId = 0,
-            ChunkSizeLimit chunkSizeLimit = ChunkSizeLimit.Large,
-            PoolSizeIncrement poolSizeIncrement = PoolSizeIncrement.Default)
-        {
-            if (Ptc.State == PtcState.Disabled)
-            {
-                PreparePoolDefault(groupId, (int)chunkSizeLimit, (int)poolSizeIncrement);
-            }
-            else
-            {
-                PreparePoolSlim((int)chunkSizeLimit, (int)poolSizeIncrement);
-            }
-        }
-
-        private static void PreparePoolDefault(int groupId, int chunkSizeLimit, int poolSizeIncrement)
-        {
-            // Prepare the pool for this thread, ideally using an existing one from the specified group.
-
-            if (_instance == null)
-            {
-                var pools = GetPools(groupId);
-                lock (pools)
-                {
-                    _instance = (pools.Count != 0) ? pools.Pop() : new(chunkSizeLimit, poolSizeIncrement);
-                }
-            }
-        }
-
-        private static void PreparePoolSlim(int chunkSizeLimit, int poolSizeIncrement)
-        {
-            // Prepare the pool for this thread.
-
-            if (_instance == null)
-            {
-                _instance = new(chunkSizeLimit, poolSizeIncrement);
-            }
-        }
-
-        public static void ResetPool(int groupId = 0)
-        {
-            if (Ptc.State == PtcState.Disabled)
-            {
-                ResetPoolDefault(groupId);
-            }
-            else
-            {
-                ResetPoolSlim();
-            }
-        }
-
-        private static void ResetPoolDefault(int groupId)
-        {
-            // Reset, limit if necessary, and return the pool for this thread to the specified group.
-
-            if (_instance != null)
-            {
-                var pools = GetPools(groupId);
-                lock (pools)
-                {
-                    _instance.Clear();
-                    _instance.ChunkSizeLimiter();
-                    pools.Push(_instance);
-
-                    _instance = null;
-                }
-            }
-        }
-
-        private static void ResetPoolSlim()
-        {
-            // Reset, limit if necessary, the pool for this thread.
-
-            if (_instance != null)
-            {
-                _instance.Clear();
-                _instance.ChunkSizeLimiter();
-            }
-        }
-
-        public static void DisposePools()
-        {
-            if (Ptc.State == PtcState.Disabled)
-            {
-                DisposePoolsDefault();
-            }
-            else
-            {
-                DisposePoolSlim();
-            }
-        }
-
-        private static void DisposePoolsDefault()
-        {
-            // Resets any static references to the pools used by threads for each group, allowing them to be garbage collected.
-
-            foreach (var pools in _pools.Values)
-            {
-                foreach (var instance in pools)
-                {
-                    instance.Dispose();
-                }
-
-                pools.Clear();
-            }
-
-            _pools.Clear();
-        }
-
-        private static void DisposePoolSlim()
-        {
-            // Dispose the pool for this thread.
-
-            if (_instance != null)
-            {
-                _instance.Dispose();
-
-                _instance = null;
-            }
-        }
-
-        private List<T[]> _pool;
-        private int _chunkIndex = -1;
-        private int _poolIndex = -1;
-        private int _chunkSizeLimit;
-        private int _poolSizeIncrement;
-
-        private ThreadStaticPool(int chunkSizeLimit, int poolSizeIncrement)
-        {
-            _chunkSizeLimit = chunkSizeLimit;
-            _poolSizeIncrement = poolSizeIncrement;
-
-            _pool = new(chunkSizeLimit * 2);
-
-            AddChunkIfNeeded();
-        }
-
-        public T Allocate()
-        {
-            if (++_poolIndex >= _poolSizeIncrement)
-            {
-                AddChunkIfNeeded();
-
-                _poolIndex = 0;
-            }
-
-            return _pool[_chunkIndex][_poolIndex];
-        }
-
-        private void AddChunkIfNeeded()
-        {
-            if (++_chunkIndex >= _pool.Count)
-            {
-                T[] pool = new T[_poolSizeIncrement];
-
-                for (int i = 0; i < _poolSizeIncrement; i++)
-                {
-                    pool[i] = new T();
-                }
-
-                _pool.Add(pool);
-            }
-        }
-
-        public void Clear()
-        {
-            _chunkIndex = 0;
-            _poolIndex = -1;
-        }
-
-        private void ChunkSizeLimiter()
-        {
-            if (_pool.Count >= _chunkSizeLimit)
-            {
-                int newChunkSize = _chunkSizeLimit / 2;
-
-                _pool.RemoveRange(newChunkSize, _pool.Count - newChunkSize);
-                _pool.Capacity = _chunkSizeLimit * 2;
-            }
-        }
-
-        private void Dispose()
-        {
-            _pool = null;
-        }
-    }
-}
author	FICTURE7 <FICTURE7@gmail.com>	2021-08-17 22:08:34 +0400
committer	GitHub <noreply@github.com>	2021-08-17 15:08:34 -0300
commit	22b2cb39af00fb8881e908fd671fbf57a6e2db2a (patch)
tree	a79e2df801d7f16a33ff50b3c5bfed303cb476e9 /ARMeilleure/Common/ThreadStaticPool.cs
parent	cd4530f29c6a4ffd1b023105350b0440fa63f47b (diff)