diff options
| author | gdkchan <gab.dark.100@gmail.com> | 2020-03-09 19:29:34 -0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-03-10 09:29:34 +1100 |
| commit | 61d79facd1740264dadb6c62a0af21179bf6672b (patch) | |
| tree | 4e5769fb13b3dea1be5b5977c7fdad3a9d8db01f /ARMeilleure/CodeGen/X86/Assembler.cs | |
| parent | e2bb5e8091125ec626fca0f1f7213463b68b54e6 (diff) | |
Optimize x64 loads and stores using complex addressing modes (#972)
* Optimize x64 loads and stores using complex addressing modes
* This was meant to be used for testing
Diffstat (limited to 'ARMeilleure/CodeGen/X86/Assembler.cs')
| -rw-r--r-- | ARMeilleure/CodeGen/X86/Assembler.cs | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/ARMeilleure/CodeGen/X86/Assembler.cs b/ARMeilleure/CodeGen/X86/Assembler.cs index 4568253a..70130d90 100644 --- a/ARMeilleure/CodeGen/X86/Assembler.cs +++ b/ARMeilleure/CodeGen/X86/Assembler.cs @@ -14,6 +14,8 @@ namespace ARMeilleure.CodeGen.X86 private const byte RexWPrefix = 0x48; private const byte LockPrefix = 0xf0; + private const int MaxRegNumber = 15; + [Flags] private enum InstructionFlags { @@ -842,10 +844,7 @@ namespace ARMeilleure.CodeGen.X86 { X86Register shiftReg = (X86Register)source.GetRegister().Index; - if (shiftReg != X86Register.Rcx) - { - throw new ArgumentException($"Invalid shift register \"{shiftReg}\"."); - } + Debug.Assert(shiftReg == X86Register.Rcx, $"Invalid shift register \"{shiftReg}\"."); source = null; } @@ -1080,6 +1079,8 @@ namespace ARMeilleure.CodeGen.X86 if (baseReg.Index >= 8) { + Debug.Assert((uint)baseReg.Index <= MaxRegNumber); + rexPrefix |= RexPrefix | (baseReg.Index >> 3); } @@ -1091,13 +1092,12 @@ namespace ARMeilleure.CodeGen.X86 { int indexReg = memOp.Index.GetRegister().Index; - if (indexReg == (int)X86Register.Rsp) - { - throw new ArgumentException("Using RSP as index register on the memory operand is not allowed."); - } + Debug.Assert(indexReg != (int)X86Register.Rsp, "Using RSP as index register on the memory operand is not allowed."); if (indexReg >= 8) { + Debug.Assert((uint)indexReg <= MaxRegNumber); + rexPrefix |= RexPrefix | (indexReg >> 3) << 1; } |